Fix E721 warnings for .pyx files #36036

jhpalmieri · 2023-08-04T21:12:52Z

Fix E721 warnings for .pyx files

pycodestyle reports: "E721 do not compare types, for exact checks use is / is not, for instance checks use isinstance()." So replace type(x) == str with isinstance(x, str), replace type(x) != type(y) with type(x) is not type(y), etc. This is a followup to #36032 which dealt with .py files.

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

pycodestyle reports: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`. So replace `type(x) == str` with `isinstance(x, str)`, replace `type(x) != type(y)` with `type(x) is not type(y)`, etc.

src/sage/rings/integer.pyx

src/sage/libs/coxeter3/coxeter.pyx

jhpalmieri · 2023-08-05T21:21:49Z

Thank you for the suggestions; I've implemented them.

jhpalmieri · 2023-08-05T21:23:03Z

I'm not sure how much of an effect "Resolve conversation" has, but it's fun to click buttons...

mkoeppe · 2023-08-05T21:27:43Z

I'm not sure how much of an effect "Resolve conversation" has

It just collapses the comments for all readers. Good idea to do when a comment has been taken care of and you're not adding a response.

jhpalmieri · 2023-08-05T21:36:13Z

Thanks! I will rebase on the next beta when it's released.

jhpalmieri · 2023-08-06T03:57:57Z

This merges cleanly with 10.1.beta9 as is.

vbraun · 2023-08-10T23:02:22Z

Doesn't build, but somehow has positive review

mkoeppe · 2023-08-10T23:41:37Z

Indeed

[sagelib-10.1.beta8]     [7/9] Cythonizing sage/rings/integer.pyx
[sagelib-10.1.beta8]     [9/9] Cythonizing sage/structure/category_object.pyx
[sagelib-10.1.beta8] 
[sagelib-10.1.beta8]     Error compiling Cython file:
[sagelib-10.1.beta8]     ------------------------------------------------------------
[sagelib-10.1.beta8]     ...
[sagelib-10.1.beta8]             if isinstance(m, Integer):
[sagelib-10.1.beta8]                 elog = self.exact_log(m)
[sagelib-10.1.beta8]                 if elog == -sage.rings.infinity.infinity or m**elog == self:
[sagelib-10.1.beta8]                     return elog
[sagelib-10.1.beta8] 
[sagelib-10.1.beta8]             if (isinstance(m, Rational):
[sagelib-10.1.beta8]                                       ^
[sagelib-10.1.beta8]     ------------------------------------------------------------
[sagelib-10.1.beta8] 
[sagelib-10.1.beta8]     sage/rings/integer.pyx:2860:35: Expected ')', found ':'
[sagelib-10.1.beta8]     Traceback (most recent call last):

github-actions · 2023-08-11T03:23:27Z

Documentation preview for this PR (built with commit d57321a; changes) is ready! 🎉

Fix E721 warnings for .pyx files

0dac5c1

pycodestyle reports: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`. So replace `type(x) == str` with `isinstance(x, str)`, replace `type(x) != type(y)` with `type(x) is not type(y)`, etc.

jhpalmieri force-pushed the E721-pyx branch from 26204d9 to 0dac5c1 Compare August 4, 2023 21:14

jhpalmieri added p: minor / 4 s: needs review c: python3 labels Aug 4, 2023